[PATCH xserver 2/4] present: Fix swapping of PresentCompleteNotify events

Alan Coopersmith alan.coopersmith at oracle.com
Mon May 7 21:37:59 UTC 2018


On 05/ 7/18 02:21 PM, Adam Jackson wrote:
> The code would fall through to the PresentIdleNotify case, and nothing
> good would come of it.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  present/present_event.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/present/present_event.c b/present/present_event.c
> index c222dd5ffe..9aebfdfced 100644
> --- a/present/present_event.c
> +++ b/present/present_event.c
> @@ -91,6 +91,7 @@ present_event_swap(xGenericEvent *from, xGenericEvent *to)
>          swapl(&c->serial);
>          swapll(&c->ust);
>          swapll(&c->msc);
> +        break;
>      }
>      case PresentIdleNotify:
>      {
> @@ -99,6 +100,7 @@ present_event_swap(xGenericEvent *from, xGenericEvent *to)
>          swapl(&c->window);
>          swapl(&c->serial);
>          swapl(&c->idle_fence);
> +        break;
>      }
>      }
>  }
> 

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-               alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - https://blogs.oracle.com/alanc


More information about the xorg-devel mailing list