[PATCH xserver] xwayland: use wl_surface_damage_buffer

Adam Jackson ajax at nwnk.net
Wed Nov 7 17:24:54 UTC 2018


On Mon, 2018-11-05 at 18:25 +0000, Simon Ser wrote:
> On Monday, November 5, 2018 3:24 PM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > I don't think it's a good idea to break Xwayland completely on
> > compositors that don't implement wl_surface version 4 or greater.
> > 
> > It would make sense to bind wl_compositor min(version, 4).
> 
> This is intentional. I think it's reasonable to expect wl_compositor v4, it's
> pretty old (3 years old). For instance, compositors not implementing v4 have no
> damage tracking with EGL.
> 
> I think it's worth it to require v4 rather than cluttering the codebase with
> version checks.

I tend to agree. weston, mutter, and wlroots seem to all support it.
wlc doesn't but it's been deprecated. I don't know how to look this up
for KDE easily short of installing and running it; if someone could
verify that it implements v4 then I'd be happy to see this merged.

- ajax



More information about the xorg-devel mailing list