[PATCH] xfree86: Only switch to original VT if it is active.

Adam Jackson ajax at nwnk.net
Fri Oct 12 14:18:11 UTC 2018


On Thu, 2018-10-11 at 16:45 +0200, Michal Srb wrote:
> If the X server is terminated while its VT is not active, it should
> not change the current VT.
> ---
> Changing the VT in that situation serves no purpose and can be confusing.
> For example when a user's graphical session is terminated while other
> user is using the computer, it would switch the VT he is working on.

Conceptual ack. Would slightly prefer to see this done by
VT_GETSTATE/VT_GETACTIVE ioctl (depending which OS you're on). It
should be simpler, and also...

> diff --git a/hw/xfree86/common/xf86Privstr.h b/hw/xfree86/common/xf86Privstr.h
> index 55d1b2455..e4d827dee 100644
> --- a/hw/xfree86/common/xf86Privstr.h
> +++ b/hw/xfree86/common/xf86Privstr.h
> @@ -61,6 +61,7 @@ typedef struct {
>      Bool dontVTSwitch;
>      Bool autoVTSwitch;
>      Bool ShareVTs;
> +    Bool hasVT;
>      Bool dontZap;
>      Bool dontZoom;

... this struct is ABI (sigh) so the fix would be unsuitable for a
stable release.

- ajax



More information about the xorg-devel mailing list