[PATCH xf86-input-synaptics] Use fabs() instead of abs() on double values.

Matthieu Herrb matthieu at herrb.eu
Sun Feb 10 16:29:22 UTC 2019


Silences clang warnings.

Signed-off-by: Matthieu Herrb <matthieu at herrb.eu>
---
 src/synaptics.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/synaptics.c b/src/synaptics.c
index 930d02e..bc2d2af 100644
--- a/src/synaptics.c
+++ b/src/synaptics.c
@@ -2602,7 +2602,7 @@ HandleScrolling(SynapticsPrivate * priv, struct SynapticsHwState *hw,
 
         priv->scroll.delta_y += priv->scroll.coast_speed_y * dtime * abs(para->scroll_dist_vert);
         delay = MIN(delay, POLL_MS);
-        if (abs(priv->scroll.coast_speed_y) < ddy) {
+        if (fabs(priv->scroll.coast_speed_y) < ddy) {
             priv->scroll.coast_speed_y = 0;
             priv->scroll.packets_this_scroll = 0;
         }
@@ -2617,7 +2617,7 @@ HandleScrolling(SynapticsPrivate * priv, struct SynapticsHwState *hw,
         double ddx = para->coasting_friction * dtime;
         priv->scroll.delta_x += priv->scroll.coast_speed_x * dtime * abs(para->scroll_dist_horiz);
         delay = MIN(delay, POLL_MS);
-        if (abs(priv->scroll.coast_speed_x) < ddx) {
+        if (fabs(priv->scroll.coast_speed_x) < ddx) {
             priv->scroll.coast_speed_x = 0;
             priv->scroll.packets_this_scroll = 0;
         }
@@ -2673,8 +2673,8 @@ clickpad_guess_clickfingers(SynapticsPrivate * priv,
              * really, this should be dependent on the touchpad size. Also,
              * you'll need to find a touchpad that doesn't lie about it's
              * size. Good luck. */
-            if (abs(x1 - x2) < (priv->maxx - priv->minx) * .3 &&
-                abs(y1 - y2) < (priv->maxy - priv->miny) * .3) {
+            if (fabs(x1 - x2) < (priv->maxx - priv->minx) * .3 &&
+                fabs(y1 - y2) < (priv->maxy - priv->miny) * .3) {
                 close_point |= (1 << j);
                 close_point |= (1 << i);
             }
-- 
2.20.1



More information about the xorg-devel mailing list