[PATCH] result parameter for ScreenWakeupHandlerProcPtr should be unsigned long

Matt Turner mattst88 at gmail.com
Wed Jan 9 19:02:34 UTC 2019


On Wed, Jan 9, 2019 at 10:03 AM Kevin Brace <kevinbrace at gmx.com> wrote:
>
> Hi Dave,
>
> I do see what is going on, but was there a mistake in the X Server header file when the ABI was changed?
> Who else uses ScreenWakeupHandlerProcPtr and does another device driver have this issue?

Can we please try to keep discussion of one issue to one thread? This
is now the third separate thread on this list about this issue.

Also, please do not top quote.

As I said in the other thread, the result parameter is not even used
by -savage, so just change -savage and move on. I don't remember
finding any other drivers that used ScreenWakeupHandlerProcPtr, but
you can certainly confirm by cloning the repos and grepping. There's
no need to ask a question if you can easily answer it yourself
definitively.

I don't know that the s/unsigned long/int/ change (which was done in
xserver commit fb0802113b4c57819cba15d64baf79bf4148607e) was a mistake
-- seems more like a simplification while the ABI was being changes
anyway.


More information about the xorg-devel mailing list