[PATCH libXext] add ACLOCAL_AMFLAGS = -I m4 to make aclocal pick ax_gcc_builtin.m4

Alan Coopersmith alan.coopersmith at oracle.com
Sun Mar 17 18:20:30 UTC 2019


On 3/17/19 10:33 AM, Matthieu Herrb wrote:
> On Sun, Mar 17, 2019 at 09:07:00AM -0700, Alan Coopersmith wrote:
>> On 3/17/19 6:29 AM, Matthieu Herrb wrote:
>>> Signed-off-by: Matthieu Herrb <matthieu at herrb.eu>
>>> ---
>>>    Makefile.am | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Makefile.am b/Makefile.am
>>> index b76bc6c..4f5c67d 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -1,5 +1,7 @@
>>>    SUBDIRS = man src specs
>>> +ACLOCAL_AMFLAGS = -I m4
>>> +
>>>    pkgconfigdir = $(libdir)/pkgconfig
>>>    pkgconfig_DATA = xext.pc
>>>
>>
>> Hmm, the build worked fine for me here - what does this fix that I
>> missed?
> 
> On OpenBSD, using automake 1.12 and autoconf 2.69, autoconf doesn't
> find ax_gcc_builtin.m4 and configure ends eup with a stray
> 
> AX_GCC_BUILTIN([__builtin_popcountl])
> 
> line, causing a syntax error.
> 
> All other X.Org modules that provide ax_*.m4 files in m4, have the
> "ACLOCAL_AMFLAGS = -I m4" line in Makefile.am.
> (And autoreconf suggests to add it when missing)

Huh, I guess either automake 1.15 or my build scripts hid that from me.

In that case, apologies and:

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-               alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - https://blogs.oracle.com/alanc


More information about the xorg-devel mailing list