[PATCH 4/9] xkbtext: fix copy-paste error

Konstantin Kharlamov Hi-Angel at yandex.ru
Sat Mar 23 23:51:58 UTC 2019


As can be seen in diff, nOut is always 0 here. The code was likely
copy-pasted from comparisons further below.

Fixes LGTM warning "Comparison is always false because nOut <= 0."

Signed-off-by: Konstantin Kharlamov <Hi-Angel at yandex.ru>
---
 xkb/xkbtext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xkb/xkbtext.c b/xkb/xkbtext.c
index d2a2567fc..54cca3fb4 100644
--- a/xkb/xkbtext.c
+++ b/xkb/xkbtext.c
@@ -966,7 +966,7 @@ CopySetLockControlsArgs(XkbDescPtr xkb, XkbAction *action, char *buf, int *sz)
         int nOut = 0;
 
         if (tmp & XkbRepeatKeysMask) {
-            snprintf(tbuf, sizeof(tbuf), "%sRepeatKeys", (nOut > 0 ? "+" : ""));
+            snprintf(tbuf, sizeof(tbuf), "RepeatKeys");
             TryCopyStr(buf, tbuf, sz);
             nOut++;
         }
-- 
2.21.0



More information about the xorg-devel mailing list