Would any Apple user be kind enough to check this trivial X server patch?

Adam Richter adamrichter4 at gmail.com
Sat May 4 14:16:51 UTC 2019

Hi, again.

Thanks to Walter Harms for his feedback on my previous proposed patch
to xserver/hw/xquarts/darwin.c, to which Walter requested replacement
of all of the assert statements.  I have attached an updated but
untested patch that attempts to accommodate that request.

Walter is not an Apple user and nobody else has responded to my
request for an Apple user to try my patch.  If anyone wants to try
this patch or provide further feedback, that would be most welcome.
If I don't get any further response in the next couple of day, I
expect I will submit it on the Gitlab server.

Thanks in advance for any further review of this.


On Thu, May 2, 2019 at 1:02 PM Adam Richter <adamrichter4 at gmail.com> wrote:
> Hi.
> The attached patch fixes three places in hw/xquartz/darwin.c that
> relied on side effects in assert parameters.  That is, they would fail
> if assert() were replaced with a macro that did not evaluate its
> parameters.
> I would appreciate it if anyone with an appropriate Apple system would
> try this trivial patch and let me know the results.  Critiques of this
> patch are also welcome, of course.  If I do not get a response to this
> in the next day or two, I expect I will submit the patch on the gitlab
> server, but having someone actually build and run it first would be
> much better.
> Thanks in advance for any responses.
> Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: darwin-assert-v2.diff
Type: text/x-diff
Size: 3532 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20190504/e3e0be07/attachment.diff>

More information about the xorg-devel mailing list