[PATCH 3/3] omap: Add proper name for DSI output

Tony Lindgren tony at atomide.com
Mon Jan 27 21:43:48 UTC 2020


Hi,

* Rob Clark <robdclark at chromium.org> [200127 21:24]:
> I *think* gitlab[1] merge merge requests are the preferred way to
> submit patches these days.  (But tbh I've not followed xorg-devel much
> since xf86-video-modesetting + glamor relieved me from needing a ddx
> driver)

OK

I think we have omap4 basically permanently stuck with this driver
because of there are no current sgx user space blobs available. Not
sure what all it would take for xf86-video-modesetting + glamor type
solution and if it could even be done with the available blobs.

> Possibly Tomi or someone who still has some omap hw should create an
> account on gitlab and get the necessary permissions to merge MRs (or
> push via git cmdline)
> 
> [1] https://gitlab.freedesktop.org/xorg/driver/xf86-video-omap

OK yeah let's see if Tomi or Sebastian can do that. Also I noticed one
issue below..

> On Sun, Jan 26, 2020 at 8:01 PM Tony Lindgren <tony at atomide.com> wrote:
> >
> > Otherwise xrandr shows the name as "Unkonwn16-1" instead of DSI-1.
> > Presumably output 15 is also DSI as there are two instances.
> >
> > Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > Cc: Matthijs van Duin <matthijsvanduin at gmail.com>
> > Cc: Merlijn Wajer <merlijn at wizzup.org>
> > Cc: Rob Clark <robdclark at chromium.org>
> > Cc: Sebastian Reichel <sre at kernel.org>
> > Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
> > Signed-off-by: Tony Lindgren <tony at atomide.com>
> > ---
> >  src/drmmode_display.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> > --- a/src/drmmode_display.c
> > +++ b/src/drmmode_display.c
> > @@ -1043,6 +1043,8 @@ const char *output_names[] = { "None",
> >                 "HDMI",
> >                 "TV",
> >                 "eDP",
> > +               "DSI",
> > +               "DSI",

The first DSI here is wrong, these should match with basically
what drivers/gpu/drm/drm_connector.c drm_connector_enum_list[]
has for DRM_MODE_CONNECTOR_* defines, meaning 15 is "Virtual",
16 is "DSI", 17 is "DPI".

Regards,

Tony


More information about the xorg-devel mailing list