[Bug 32188] radeon evergreen (5xxx) segfault (Komodo Edit, other apps)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32188

--- Comment #44 from Alex Deucher <agd5f at yahoo.com> 2011-01-24 08:00:16 PST ---
(In reply to comment #41)
> 
> There have certainly been cases where EXA called the Prepare/Done hooks but not
> the actual operation hook in between. Dave fixed at least one of them at some
> point, though it might still be a good idea to make the driver robust against
> this.
> 
> I've been wondering if any of these issues might be related to running out of
> CS space during operation hook calls. The hooks in radeon_exa_funcs.c and
> radeon_exa_render.c handle this by calling the Done hook followed by
> radeon_cs_flush_indirect(), but I can't seem to find any corresponding code for
> >= R6xx.

We shouldn't run out of CS space during the op hook calls since we are using
vbos not inline verts.

> 
> Why would this no longer be necessary? Where is it checked whether the constant
> buffer will fit?

The cbuf bo is NULL at this point due to the radeon_vbo_put() just before so
the code is no longer necessary.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.