[Xorg] Strange crashes caused by radeon pagesize cleanup/update?

[Tarmo Tänav]

I mixed some things up:

06-30        -- WORKS
06-30 no DRI -- WORKS
07-09        -- CRASH
07-09 no DRI -- WORKS
07-13        -- CRASH
07-13 no DRI -- CRASH


> Sorry, the correct link for radeon_dri.c is actually:
> http://freedesktop.org/cgi-bin/viewcvs.cgi/xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_dri.c?r1=1.4&r2=1.5&root=xorg
>
>> The latest X.org (from CVS date:2004-07-13) seems to crash while opening
>> or resizing some gtk windows, I didn't investigate it much, but server
>> crashes (Fatal server error: Caught signal 11.  Server aborting) were
>> caused by opening xfce4-mixer, evolution-1.5, gtk file save dialog,
>> rhythmbox (all of those, including gtk are also latest CVS versions,
>> but I don't think gtk could cause this).
>>
>> Anyway, I tried Xorg from 2004-07-09 and it worked fine, then I applied
>> the updates to radeon_dri.c and r128_dri.c and got the same problem as
>> with 2004-07-13.
>>
>> I'm also using the latest radeon drm driver from Xorg cvs, radeon 9000
>> pro 64MB, gcc-3.4.1 (also tried 3.3.3), linux-2.6.7-rc3,
>> glibc-2.3.4.20040619.
>>
>> (btw. I made a small test program and getpagesize() did return 4096.)
>>
>> -- This seem to be the cause of the problem:
>> http://freedesktop.org/cgi-bin/viewcvs.cgi/xc/programs/Xserver/hw/xfree86/drivers/ati/r128_dri.c?r1=1.3&r2=1.4&root=xorg
>>
>> It's also possible that the problem occurs on r128 but I can't test
>> that.
>> Strange thing is that the patch is very simple and doesn't look like it
>> could cause the server to crash, but maybe I'm missing something.