running ident on modular xorg tree
Daniel Stone
daniel at freedesktop.org
Wed Sep 8 18:07:53 PDT 2004
On Wed, Sep 08, 2004 at 05:03:03PM -0700, Ian Romanick wrote:
> Jim Gettys wrote:
> >Certainly alot of the X code is reasonably consistent, but there
> >are parts that are not.
> >
> >It is certainly the case we should document what "X Window System"
> >indenting style is, and encourage new code to conform.
> >
> >As far as stuff that does not conform, I claim it should probably
> >only be done on a case by case basis, on egregiously bad indenting....
>
> Over the years I've changed my indent style a couple times. Each time I
> do, I make an effort to *not* change old code. When I look at code that
> has obviously non-conformant indentation, it throws up a big red flag,
> "This code hasn't been touched in a long time." Sometimes that's useful.
Ah, but when they're mixed -- that's when it truly sucks. Find someone
that uses four spaces, set et and ts=4, and watch the rest of the code
suddenly fail to make sense.
--
Daniel Stone <daniel at freedesktop.org>
freedesktop.org: powering your desktop http://www.freedesktop.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20040908/be17d548/attachment.pgp>
More information about the xorg
mailing list