[patch] Another savage bugfix and new xorg tree

[Sérgio Monteiro Basto]

Hello,
a little of cross posting.
well
I apply all patch of savage on xorg cvs to a clean X11R6.8.1 source 
after this applied the patch suggest by Felix and all seems worked has
worked before.

Found that all videos-modes except the first one (1024x768 24/32 bpp)
have a similar problem that was found in some little movies with xv
drive, Tux Racer (but this time mouse works better, pointing well the
location of the screen).

savage-duo-full.tar.gz hasn't been applied yet .



Develop the drive under xorg cvs doesn't seem, to me, a good idea, 
dri and xorg be 2 different projects, still seems, to me, a good idea.
Conclusion begging develop dri drives, drms and Mesa over one
Xorg-R6.8.1 for me sounds perfect.
Creating other tree doesn't seem very difficult and we don't have to
erase or finish trunk tree either.
thanks for your time :),

On Sat, 2004-09-18 at 15:47, Felix Kühling wrote:
> Hello,
> 
> below is another bugfix for the savage 2D driver. It moves vbeFree in
> SavageCloseScreen to after SavageWriteMode. It's still needed there if
> the UseBios option is set. This fixes a "Frequency not supported"
> problem my monitor has after the Xserver terminates.
> 
> I'm unsure how strict CVS policies are in Xorg. I don't feel comfortable
> yet, committing stuff to the 2D driver that I don't fully understand
> because it may have unexpected effects on other parts of the code or on
> different hardware. If someone tells me not to worry too much when we're
> far from a release deadline I could commit such small fixes without
> asking in the future. If someone prefers to review my patches first,
> that's fine with me too. Let me know what you prefer.
> 
> Is there an official maintainer of the Savage driver who I should refer
> to?
> 
> Best regards,
>   Felix
> 
> | Felix Kühling <fxkuehl at gmx.de>                     http://fxk.de.vu |
> | PGP Fingerprint: 6A3C 9566 5B30 DDED 73C3  B152 151C 5CC1 D888 E595 |
> 
> --- ./savage_driver.c.~1.7.~	2004-09-17 12:45:48.000000000 +0200
> +++ ./savage_driver.c	2004-09-18 16:29:12.000000000 +0200
> @@ -3341,10 +3341,6 @@
>      }
>  #endif
>  
> -    if (psav->pVbe)
> -      vbeFree(psav->pVbe);
> -    psav->pVbe = NULL;
> -
>      if( psav->AccelInfoRec ) {
>          XAADestroyInfoRec( psav->AccelInfoRec );
>  	psav->AccelInfoRec = NULL;
> @@ -3364,6 +3360,11 @@
>  	SavageUnmapMem(pScrn, 0);
>      }
>  
> +    /* This is still needed in SavageWriteMode. */
> +    if (psav->pVbe)
> +      vbeFree(psav->pVbe);
> +    psav->pVbe = NULL;
> +
>      pScrn->vtSema = FALSE;
>      pScreen->CloseScreen = psav->CloseScreen;
>  
> _______________________________________________
> xorg mailing list
> xorg at freedesktop.org
> http://freedesktop.org/mailman/listinfo/xorg
-- 
Sérgio M. B.