[PATCH] EXA support for i830 (for real this time!)

[Jesse Barnes]

On Friday, August 26, 2005 9:40 am, Alan Hourihane wrote:
> On Thu, 2005-08-25 at 21:09 -0700, Jesse Barnes wrote:
> > Ok, this one actually works (for me anyway).  Stuff this patch into
> > your i810 driver subdirectory, build it, add "AccelMethod" "EXA" to
> > your driver section and "Composite" "Enable" to your Extensions
> > section, run xcompmgr -s and it should be pretty usable.
> >
> > TODO list:
> >   o get review from alanh
> >   o put XAA and EXA stuff in separate files (and other
> >     cleanup/refactoring)
> >   o deal with dual head and Xv correctly (totally untested)
> >   o add Composite hook support
> >
> > Please test and send feedback!
>
> I've reviewed the patch, and you are absolute right that the TODO list
> above needs attention. There's a few other things where you've wrapped
> stuff around with I830_USE_XAA which should need an EXA equivalent,
> especially syncing the hardware too.

Forgot one too:
  o implement Upload/DownloadToScreen

though apparently it doesn't help much on most machines.

To fix dual head, I should probably put the offscreen area after both 
front buffers, using the FrontBuffer pool?  And Xv is just broken but is 
theoretically easy since I'm just changing the way memory is allocated 
over to use the EXA routine.

> Thanks for taking on this task.

Thanks for the review, I'll try and fix up the remaining bugs so that 
this is RC1 worthy (at least as an experimental feature) and then start 
working on the missing features (Composite and Upload/Download).

Thanks,
Jesse