EXA for radeon experimental patch

[Anthony Romano]

I fixed it

it appears line 28 of radeon_exa.c was the problem, it was commented
out. I deleted it, and it compiled, now waiting on the rest of xorg

On 8/30/05, Anthony Romano <dominatus at gmail.com> wrote:
> In file included from radeon_exa.c:617:
> radeon_exa_funcs.c: In function `RADEONPrepareSolidCP':
> radeon_exa_funcs.c:55: error: request for member `pattern' in
> something not a structure or union
> radeon_exa_funcs.c:55: error: request for member `pattern' in
> something not a structure or union
> radeon_exa_funcs.c: In function `RADEONPrepareCopyCP':
> radeon_exa_funcs.c:117: error: request for member `rop' in something
> not a structure or union
> radeon_exa_funcs.c:117: error: request for member `rop' in something
> not a structure or union
> radeon_exa_funcs.c: In function `RADEONUploadToScreenCP':
> radeon_exa_funcs.c:193: warning: suggest parentheses around assignment
> used as truth value
> radeon_exa_funcs.c: In function `RADEONDownloadFromScreenCP':
> radeon_exa_funcs.c:247: warning: unused variable `info'
> radeon_exa.c: At top level:
> radeon_exa_funcs.c:372: warning: `RADEONUploadToScratchMMIO' defined
> but not used
> radeon_exa_funcs.c:436: warning: `RADEONScratchSaveMMIO' defined but not used
> radeon_exa.c:389: warning: `R200CheckComposite' defined but not used
> radeon_exa.c:418: warning: `R200PrepareComposite' defined but not used
> radeon_exa.c:548: warning: `R200Composite' defined but not used
> radeon_exa.c:612: warning: `R200DoneComposite' defined but not used
> radeon_exa_funcs.c:372: warning: `RADEONUploadToScratchCP' defined but not used
> radeon_exa_funcs.c:436: warning: `RADEONScratchSaveCP' defined but not used
> make[7]: *** [radeon_exa.o] Error 1
> make[7]: Leaving directory
> `/home/tony/xc/programs/Xserver/hw/xfree86/drivers/ati'
> make[6]: *** [all] Error 2
> make[6]: Leaving directory `/home/tony/xc/programs/Xserver/hw/xfree86/drivers'
> make[5]: *** [all] Error 2
> make[5]: Leaving directory `/home/tony/xc/programs/Xserver/hw/xfree86'
> make[4]: *** [hw/xfree86] Error 2
> make[4]: Leaving directory `/home/tony/xc/programs/Xserver'
> make[3]: *** [all] Error 2
> make[3]: Leaving directory `/home/tony/xc/programs'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/home/tony/xc'
> make[1]: *** [World] Error 2
> make[1]: Leaving directory `/home/tony/xc'
> make: *** [World] Error 2
> 
> 
> Any ideas?
> 
> On 8/30/05, Anthony Romano <dominatus at gmail.com> wrote:
> > Ill test this out tonight on an r200
> >
> > On 8/30/05, Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> > > Hi !
> > >
> > > Here you can find a patch that adds EXA for radeon. Heavily based on the
> > > initial patch from Eric Anholt. What this patch does _NOT_ do yet:
> > >
> > >  - Composite hooks aren't there. You can enable the r200 hooks though
> > > but they haven't been tested
> > >  - Xv is untested and possibly still broken on various configs
> > >
> > > What this patch does do that is not related to exa (yah, I know ...) :
> > >
> > >  - Fixes r300 endian problems with color expansion and XAA. Note that Xv
> > > may still be broken in various combinations of image types vs. endian.
> > > The solution might not be terrific but I couldn't find a hardware
> > > swapper that works.
> > >
> > > What this patch does with EXA:
> > >
> > >  - Implements solid fills and blits both with CP and MMIO
> > >  - Implements UpdateToScreen as DMA when using CP (with proper endian
> > >   for r300 hopefully, r200 is untested for now)
> > >  - DownloadFromScreen should work but is slow (no DMA). I haven't found
> > >   a scenario that causes EXA to call it though so I haven't validated
> > >   it.
> > >
> > > It still needs a lot of cleanups, it needs r100 versions of the
> > > composite code, the r200 one need to be tested and be made to work on
> > > MMIO (it shouldn't require the CP strictly speaking), and it needs
> > > somebody who understands the r300 3D engine to write r300 composite
> > > hooks (similar to Render hooks for XAA).
> > >
> > > Enjoy:
> > >
> > >  http://gate.crashing.org/~benh/radeon-exa-benh-2.diff
> > >
> > > And report any problem to me. Known problem: with current top of tree
> > > EXA implementation, it locks up if you enable the composite hooks but
> > > they return FALSE; Eric has a patch for that already (it's an EXA bug).
> > >
> > > Ben.
> > >
> > >
> > > _______________________________________________
> > > xorg mailing list
> > > xorg at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/xorg
> > >
> >
>