[PATCH] EXA support for i830 (for real this time!)

[Alan Hourihane]

On Sun, 2005-08-28 at 21:48 -0700, Jesse Barnes wrote:
> On Friday, August 26, 2005 9:40 am, Alan Hourihane wrote:
> > On Thu, 2005-08-25 at 21:09 -0700, Jesse Barnes wrote:
> > > Ok, this one actually works (for me anyway).  Stuff this patch into
> > > your i810 driver subdirectory, build it, add "AccelMethod" "EXA" to
> > > your driver section and "Composite" "Enable" to your Extensions
> > > section, run xcompmgr -s and it should be pretty usable.
> > >
> > > TODO list:
> > >   o get review from alanh
> > >   o put XAA and EXA stuff in separate files (and other
> > >     cleanup/refactoring)
> > >   o deal with dual head and Xv correctly (totally untested)
> > >   o add Composite hook support
> 
> This one addresses the cleanup aspect of things (yay lots of #ifdefs 
> removed!)--I've adding i830_xaa.c and i830_exa.c files and fixed up 
> some other related stuff.  I tested Xv and it's busted but haven't 
> fixed and tested dual head yet.  So this is more of a checkpoint than 
> anything else.

Jesse,

Another problem with your patch is the use of I830_USE_XAA and
I830_USE_EXA where you should really be using pI830->useEXA.

Think of the case that both I830_USE_XAA and I830_USE_EXA are defined.
There are places which reference XAA's AccelInfoRec that will blow up
when EXA is in use, yet the driver has been compiled with support for
both.

It's probably easier to completely remove the I830_USE_EXA and
I830_USE_XAA defines and use pI830->useEXA completely to avoid
confusion.

Alan.