CVS Update: xc (branch: trunk)

[Felix Kühling]

Am Dienstag, den 01.02.2005, 10:14 -0800 schrieb Alexander Gottwald:
> CVSROOT:	/cvs/xorg
> Module name:	xc
> Changes by:	ago at gabe.freedesktop.org	05/02/01 10:14:01
> 
> Log message:
>   2005-02-01  Alexander Gottwald  <ago at freedesktop dot org>
>   
>   	* xc/programs/Xserver/xkb/ddxLoad.c
>   	* xc/programs/Xserver/xkb/ddxList.c:
>   	Bugzilla #2245 (https://bugs.freedesktop.org/show_bug.cgi?id=2245)
>   	attachment #1649 (https://bugs.freedesktop.org/attachment.cgi?id=1649):
>   	cleanup the generation of xkbcomp command lines. Allocate them dynamicly
>   	and remove unmaintainable length calculation.

This commit broke the build for me, even with your later fix of the link
order. The problem is that os/xprintf.c is built with -ansi -pedantic.
In this case va_copy is not defined as a macro by stdarg.h (using
gcc-3.3.4 and gcc-3.3.5) and is missing when Xorg is finally linked. 

va_copy not being defined is not a new problem, I found it in an older
build log I had hanging around. The error was never found before because
no other object linked into Xorg used Xprintf before this commit. So
xprintf.o (from libos.a) was never linked. I'm not sure what the proper
fix would be. Either change the compiler flags or avoid using va_copy in
xprintf.c.

Here are the relevant error messages from my build logfile:

...
[compiling xprintf.c]
xprintf.c: In function `Xvprintf':
xprintf.c:41: warning: implicit declaration of function `va_copy'
...
[linking Xorg]
os/libos.a(xprintf.o)(.text+0xb): In function `Xvprintf':
/home/fxkuehl/snapshots/build/HEAD/xorg/programs/Xserver/os/xprintf.c:41: undefined reference to `va_copy'
os/libos.a(xprintf.o)(.text+0x69): In function `XNFvprintf':
/home/fxkuehl/snapshots/build/HEAD/xorg/programs/Xserver/os/xprintf.c:71: undefined reference to `va_copy'
collect2: ld returned 1 exit status

>
> Modified files:
>       ./:
>         ChangeLog 
>       xc/programs/Xserver/xkb/:
>         ddxLoad.c ddxList.c 
>   
>   Revision      Changes    Path
>   1.737         +10 -1     xc/ChangeLog
>   1.10          +15 -44    xc/programs/Xserver/xkb/ddxLoad.c
>   1.5           +18 -16    xc/programs/Xserver/xkb/ddxList.c

Regards,
  Felix

-- 
| Felix Kühling <fxkuehl at gmx.de>                     http://fxk.de.vu |
| PGP Fingerprint: 6A3C 9566 5B30 DDED 73C3  B152 151C 5CC1 D888 E595 |