[PATCH] Small Xorg HEAD compile fix for gcc-3.4 snapshots

Mike A. Harris mharris at www.linux.org.uk
Thu Feb 17 02:17:30 PST 2005


Patrick Mau wrote:
> Hello everyone,
> 
> I'd like to submit the following small patch to Xorg's HEAD branch. My
> local gcc snapshot complained about "non-static following static
> declaration".
> 
> I hope you don't mind the inlined patch, but it's small
> 
> Regards,
> Patrick
> 
> Index: programs/Xserver/cfb/cfbgc.c
> ===================================================================
> RCS file: /cvs/xorg/xc/programs/Xserver/cfb/cfbgc.c,v
> retrieving revision 1.3
> diff -u -u -r1.3 cfbgc.c
> --- programs/Xserver/cfb/cfbgc.c	14 Jan 2005 08:37:30 -0000	1.3
> +++ programs/Xserver/cfb/cfbgc.c	24 Jan 2005 13:15:18 -0000
> @@ -85,7 +85,7 @@
>  # define usePolyGlyphBlt	miPolyGlyphBlt
>  #endif
>  
> -void cfbUnPushPixels (GCPtr, PixmapPtr, DrawablePtr, int, int, int, int);
> +static void cfbUnPushPixels (GCPtr, PixmapPtr, DrawablePtr, int, int, int, int);
>  
>  #ifdef FOUR_BIT_CODE
>  # define usePushPixels	cfbPushPixels8
> _______________________________________________
> xorg mailing list
> xorg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg


Submit the patch in bugzilla at http://bugs.freedesktop.org in the
"xorg" branch, to ensure it does not get lost.  If I'm not mistaken,
Adam Jackson was feverishly trying to remove the cfb code entirely
from the server not long ago, so perhaps an rm -rf of that directory
would remove some more warnings too.   ;o)



More information about the xorg mailing list