radeon tiling again...

[Keith Whitwell]

Roland Scheidegger wrote:
> Michel Dänzer wrote:

>> Also, I only now noticed this comment in the DDX diff:
> 
> Well, the comment is new in this patch (and so is the code for depth
> moves, the older patches just have a "remember for later" comment, 
> forgot to mention)
> 
>> /* The Radeon has depth tiling on all the time. Rely on surface regs
>>  to + * translate the addresses (will fail if allowColorTiling is 0).
>>  */
>>
>> So depth moves will be broken when tiling is disabled? Not that 
>> they're important...
> 
> The old code ONLY ever worked for original radeons (r100, possibly
> rv200) - it could never have worked for rv100, r200, rv250, igps.
> Additionally, the old code actually had an error which not only made it
> (reasonable guess) 33% slower, but never copy the stencil buffer. Yet
> nobody (afaik) ever complained about that. I just figured it's not worth
> the hassle of doing lots of "if this card, this feature do that" code
> which is never used anyway, and only supporting it if tiling is enabled
> made the code much simpler.
> You're right though it might not be a very good idea to support depth
> moves corretly only sometimes. Guess it would in fact be better to not
> support them at all, Keith seemed to be perfectly happy with that
> solution. Will remove them.

Yes, I'm happy to see it removed.  I don't think anyone uses it and as 
you point out it's pretty rotted.

Keith