[PATCH] make some stuff in xserver/fb/fbpict.c static]

Jeff Muizelaar jeff at infidigm.net
Fri Jul 1 16:23:46 PDT 2005


On Sun, Jun 26, 2005 at 12:11:45PM +0200, Zack Rusin wrote:
> Hey,
> 
> thanks for the patch but at this point I don't think it's going to work. The 
> problem is that the rootless server uses those symbols so you can't just make 
> them static. 
> If you'd like to look at the composition code in the rootless server and 
> figure out a way of handling it a little more gracefully that'd be awesome.

Ok, it looks like the rootless server basically does fbComposite, but
accelerates it if (dstMask == FB_ALLONES && pDst->pDrawable->bitsPerPixel == 32 &&
        		width * height > rootless_CompositePixels_threshold &&
	        	SCREENREC(pDst->pDrawable->pScreen)->imp->CompositePixels). 
So how about instead of duplicating fbComposite, we move the check into
the begining of SafeAlphaComposite do the acceleration if appropriate
and otherwise call fbComposite.

If this sounds like a good approach I'll try and put together a patch
when I get the time.

-Jeff



More information about the xorg mailing list