Darwin build fails on xconsole.c

[Keith Packard]

On Wed, 2005-07-13 at 09:14 -0700, Torrey Lyons wrote:
> Since the patch of July 7 by sandmann xconsole.c fails to build on Darwin with 
> the error:
> 
> xconsole.c: In function 'get_pty':
> xconsole.c:863: error: 'PTYCHAR1' undeclared (first use in this function)
> xconsole.c:863: error: (Each undeclared identifier is reported only once
> xconsole.c:863: error: for each function it appears in.)
> xconsole.c:867: error: 'PTYCHAR2' undeclared (first use in this function)
> 
> These are defined in "../xterm/ptyx.h", which was dropped as an include in the 
> recent patch. I suppose this might have been done for the modularization work. 
> How should we fix this? Copying the definitions for PTYCHAR1 and PTYCHAR2 from 
> ptyx.h will work, but this may not be the best solution.

They should either be copied or stuck in one of the header files that
(currently) end up in the modular directory proto/X11. That's where all
of the OS abstractions currently live, although it would be nice to get
them into a dumping ground of their own rather than clutter a putatively
OS independent directory.

-keith

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20050713/d3c1b3d5/attachment.pgp>