EXA

[Eric Anholt]

On Wed, 2005-10-12 at 09:58 +0200, Thomas Winischhofer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Eric Anholt wrote:
> > On Wed, 2005-10-12 at 09:00 +0200, Lars Knoll wrote:
> > 
> >>On Wednesday 12 October 2005 06:32, Eric Anholt wrote:
> >>
> >>>On Wed, 2005-10-12 at 01:54 +0200, Thomas Winischhofer wrote:
> >>>
> >>>>-----BEGIN PGP SIGNED MESSAGE-----
> >>>>Hash: SHA1
> >>>>
> >>>>
> >>>>EXA is getting close to the point where it is entirely useless on
> >>>>hardware that doesn't accelerate render/composite.
> >>>>
> >>>>On my (admittedly slow, 400Mhz) testbox, I can actually watch KDE paint
> >>>>its default blue background.
> >>>>
> >>>>Adding some logging into the EXA hooks reveals that the driver receives
> >>>>millions (yes, millions) of calls of copy commands with a width and
> >>>>height of 1. Yes, 1. It fills the screen with 1x1 copy commands.
> >>>
> >>>Sounds like KDE is using a 1x1 pixmap for the window background, rather
> >>>than setting a solid color.  Lame.  We'll just need to do something
> >>>similar to what exaComposite does for 1x1 repeating pictures -- read out
> >>>the one pixel and solid-fill it over the whole thing.
> >>
> >>No, it's not KDE. In many cases the only way to set do solid fills in Render 
> >>is to setup a 1x1 pixmap with Repeat (at least it was up to 3 months ago). 
> >>Xft uses exactly the same scheme, feel free to check XftDrawSrcPicture in 
> >>xftdraw.c.
> >>
> >>Using 1x1 pictures with repeat has been a standard idiom in Render to do solid 
> >>fills for years. The software code in fb/ has optimised code paths for this 
> >>case. So should exa.
> > 
> > 
> > I'm not talking about pictures here -- exaTryDriverSolidFill already
> > covers solid fills with Render.  I'm talking about window background
> > painting, which I added for pixmap backgrounds in hardware recently and
> > caused the problem in question (as far as I can tell).
> 
> 
> It's not only the window background. Also text in the KDE konsole is
> updated in slow motion, speak 1x1 blits.

Could you test after my latest commit?  It should have fixed the only
case of 1x1 pixmaps getting copied over and over again, unless the app
has been doing that, itself, all along.

-- 
Eric Anholt                                     eta at lclark.edu
http://people.freebsd.org/~anholt/              anholt at FreeBSD.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20051012/29fdac36/attachment.pgp>