[Mesa3d-dev] Re: GLX indirect rendering broken

[Brian Paul]

Ian Romanick wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Brian Paul wrote:
> 
>>I've found more problems with the FASTCALL stuff in the server-side GLX
>>code.
>>
>>Ian submitted a patch to fix my previous problem with this, but I found
>>today that the glGetMapfv() function was broken.  Disabling the FASTCALL
>>macro/optimization fixes things.
>>
>>Until detailed investigation and testing can be done, I'm going to
>>totally disable FASTCALL.
> 
> 
> My opinion is that if the server-side code isn't including the right
> header files to get the correct prototypes, it's already broken.
> 
> That said, I'm not sure how any of the FASTCALL stuff could impact
> glGetMapfv at all.  Without patches that exist only in bugzilla, *none*
> of the __glGet*_size functions have been changed.  Are you sure one of
> the FASTCALL functions is the root cause?

Looks like adding the right #includes seems to fix things:

Index: render2.c
===================================================================
RCS file: /cvs/xorg/xc/programs/Xserver/GL/glx/render2.c,v
retrieving revision 1.5
diff -r1.5 render2.c
45a46
 > #include "indirect_size.h"
Index: singlesize.c
===================================================================
RCS file: /cvs/xorg/xc/programs/Xserver/GL/glx/singlesize.c,v
retrieving revision 1.7
diff -r1.7 singlesize.c
43a44
 > #include "indirect_size.h"


<rant> How the h*ll does this kind of stuff happen in the first place? 
  Are we just ignoring compiler warnings? </rant>

Sorry, but I wasted a full hour on this dumb thing.

Would someone please check in this patch?

-Brian