Patch for compiling SiS statically

[Thomas Winischhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thomas Winischhofer wrote:
> Thomas Winischhofer wrote:
> 
>>>Matthias Hopf wrote:
>>>
>>>
>>>>>On Oct 28, 05 19:25:11 +0200, Thomas Winischhofer wrote:
>>>>>
>>>>>
>>>>>
>>>>>>>the following patch is needed to compile the SiS driver (and anything
>>>>>>>potentially using setjmp/longjmp) statically.
>>>>>>>
>>>>>>>If noone objects, I'll commit the code at the beginning of the next week.
>>>>>>>
>>>>>>>Matthias
>>>>>>
>>>>>>I basically don't object, but nevertheless am surprised that noone has
>>>>>>noticed this before. Is the SiS driver really the only one using
>>>>>>setjmp/longjmp?
>>>>>
>>>>>
>>>>>Yes. It's just the module loader in xf86cfg/loader.c that needs setjmp
>>>>>as well. And that file includes <setjmp.h> itself. I'm a bit surprised
>>>>>by that.
>>>>>
>>>>>I already talked with Egbert, he has the opinion that using setjmp is
>>>>>wrong in the first place, because it gives you headaches on some
>>>>>architectures (don't know whether SiS is a valid gfx hardware on these,
>>>>>though).
>>>
>>>
>>>
>>>If you look at the file you will see that it is not. It's only used on
>>>x86/32 and AMD64.
> 
> 
> 
> Which reminds me that your patch isn's accurate. It should only include
> this if it really is needed (that is, in the #if __i386__ etc sections)

And the DESIGN documents says that xf86_libc.h must not be included
directly at all. It is said to be implicitely included by xf86_ansic.h.

I need to read up on this. Please don't commit the patch.

Thomas

- --
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net          http://www.winischhofer.net/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDYnmAzydIRAktyUcRAkSIAJ912gjkfRqyNjv9AFCa9QYGGua/AACfbjyt
mlpk2hXSSreuGnCjBVOIkYc=
=JCth
-----END PGP SIGNATURE-----