[Patch] Changes to vmware driver to fix resolution switching

Philip Langdale plangdale at vmware.com
Fri Sep 16 11:02:08 PDT 2005

Hi all,

As I'm sure some people have noticed, attempting to change resolutions
in a virtual machine using the vmware driver results in a corrupted
display. This was due to the fact that our virtual hardware always
resizes the framebuffer to the newly requested resolution with the
optimal pitch. Of course, the X server cannot cope with this as the
pitch is an assumed invariant, resulting in the messed up display.

Unfortunately, fixing this problem required changes to the virtual
hardware to support fixed-pitch mode changes, so this driver change
by itself will not instantly fix the problem. The updated virtual
hardware will be in the upcoming Workstation 5.5 release (but is
not in the currently available beta2).

The attached patch updates the driver to request pitch locking
at the appropriate times. It will continue to work correctly
with older versions of our products.

If someone could apply it to the tree, that would be much
appreciated. I don't know whether it is too late for this
to make 6.9/7.0 but if it doesn't it won't be the end of
the world as we'll be shipping a build of the driver with
our guest tools in any case.

I'm not completely familiar with how you want to handle things
like changelog entries etc; I'll be happy to provide such when I
know what's expected.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: randr-vmware.diff
Type: text/x-patch
Size: 13624 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20050916/d399eb87/attachment.bin>

More information about the xorg mailing list