Xorg crash in xf86ActivateDevice() with nvidia driver 9629

[Mitch]

 > You mean git?

Yup i meant 'git'. I've been svn'ing too much.

 > It is easy, but if we get garbage in, there's not a lot we can do.  I
 > believe ths is just NVIDIA not following (or checking for, bad!) the
 > new input ABI.

The structure seemed all but correct to me. The question is why is Xorg 
treating the Damage Extension Manger as an input device. Seems to me 
like an Xorg bug. Also changing the ABI without enabling versioning 
dependencies seems like Xorg is breaking the API. I would expect Xorg to 
refure to load the driver than crashing. Crashing is always the wrong 
thing to do, rather warn and exit than SEGV.  Are the closed binary 
vendors supposed to be monitoring the groups for ABI changes ?

-------- Original Message --------
Subject: Re: Xorg crash in xf86ActivateDevice() with nvidia driver 9629
Date: Sun, 3 Dec 2006 11:22:16 +0200
From: Daniel Stone <daniel at fooishbar.org>
To: Mitch <Mitch at HasBox.COM>
CC: xorg at lists.freedesktop.org
References: <45727BFB.50404 at HasBox.COM>

On Sun, Dec 03, 2006 at 11:25:47AM +0400, Mitch wrote:
> . Xorg from yesterdays svn

You mean git?

> However the next device is not an input device but is being recognised 
> incorrectly. Furthermore we're doing a strlen() on a NULL so we're 
> crashing (as expected). Now i know it's easy to point fingers and blame 
> nvidia, but the code we're crashing on is in xorg territory. So the next 
> device is

It is easy, but if we get garbage in, there's not a lot we can do.  I
believe ths is just NVIDIA not following (or checking for, bad!) the new
input ABI.

Cheers,
Daniel