[ANNOUNCE] xf86-video-nv 1.2.1
Andres Salomon
dilinger at debian.org
Mon Dec 18 18:46:33 PST 2006
Alan Coopersmith wrote:
> Andres Salomon wrote:
>> Alan Coopersmith wrote:
>> [...]
>>> It's failing for me too since the sed operations in the configure
>>> script aren't working with Solaris sed. config.h ends up with:
>>>
>>> /* Define to the version of this package. */
>>> #define PACKAGE_VERSION "1.2.1"
>>>
>>> /* Major version of this package */
>>> #define PACKAGE_VERSION_MAJOR
>>>
>>> /* Minor version of this package */
>>> #define PACKAGE_VERSION_MINOR 0
>>>
>>> /* Patch version of this package */
>>> #define PACKAGE_VERSION_PATCHLEVEL 0
>>>
>>> If I substitute GNU sed, it works.
>>>
>>
>> Ugh. The way we're calling sed is:
>>
>> sed -ne 's/^\([[^\.]]\+\).*/\1/p'
>> sed -ne 's/^\([[^\.]]\+\)\.\([[^\.]]\+\).*/\2/p'
>> sed -ne 's/^\([[^\.]]\+\)\.\([[^\.]]\+\)\.\([[^\.]]\+\).*/\3/p'
>>
>> Do you know what part of that Solaris sed is unhappy with?
>
> I poked around a bit and wasn't able to find why it wasn't working, but
> it appears Matthieu Herrb did:
> https://bugs.freedesktop.org/show_bug.cgi?id=9368
>
> That fixes the problem for me:
> /* Major version of this package */
> #define PACKAGE_VERSION_MAJOR 1
>
> /* Minor version of this package */
> #define PACKAGE_VERSION_MINOR 2
>
> /* Patch version of this package */
> #define PACKAGE_VERSION_PATCHLEVEL 2
>
> I'll go ahead and commit Matthieu's patch to the util-macros git
> repository.
>
Note that it's buggy w/ short versions strings; how portable is cut -s?
If it works on solaris and others, we probably want to be using that..
More information about the xorg
mailing list