Bug in xf86ProcessCommonOptions

Peter Hutterer mailinglists at who-t.net
Wed Dec 20 16:54:04 PST 2006


Extension devices that do not have "SendCoreEvents" (or any of the  
other flags) set will still send core events due to a bug in  
xf86ProcessCommonOptions().

If I understand the man pages correctly, "AlwaysCore" should be  
equivalent to "CorePointer" or "SendCoreEvents".


index 16e330d..1262de3 100644
--- a/hw/xfree86/common/xf86Xinput.c
+++ b/hw/xfree86/common/xf86Xinput.c
@@ -115,7 +115,7 @@ _X_EXPORT void
xf86ProcessCommonOptions(LocalDevicePtr local,
                           pointer	list)
{
-    if (!xf86SetBoolOption(list, "AlwaysCore", 0) ||
+    if (xf86SetBoolOption(list, "AlwaysCore", 0) ||
          xf86SetBoolOption(list, "SendCoreEvents", 0) ||
          xf86SetBoolOption(list, "CorePointer", 0) ||
          xf86SetBoolOption(list, "CoreKeyboard", 0)) {


Cheers,
   Peter

--
Multi-Pointer X Server
http://wearables.unisa.edu.au/mpx





More information about the xorg mailing list