[patch] XVideo on my Radeon

[Roland Scheidegger]

Jacek Pop?awski wrote:
> I have submitted bug report about my problem with XVideo on xorg 6.9
> / 7.0:
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=5623

> I used CVS version from 2005-08-01, compiled it, and realized that 
> XVideo is working. So I started search and found that it stopped
> working between 2005-08-25 and 2005-08-26. Problem was in file
> radeon_bios.c:
> 
> if (!RADEON_BIOS8(tmp + i*2) && i > 1) break; /* end of table */
> 
> was changed to:
> 
> if (!RADEON_BIOS16(tmp + i*2)) break; /* end of table */
> 
> When I changed back that in the current CVS - XVideo started to work!
> 
> 
> Is this the right place to discuss such problems? Or is there any 
> Radeon-related mailing-list?
This is the right place, bugzilla is certainly good too (though 
addressing this list may get broader feedback).
I'm not sure what this specific change exactly should do, it does not 
really seem to match the cvs log ("Fix bug in Radeon connector table 
parsing -- parse all entries, not just the first." - at least by just 
looking at the code it seems feasible that the old code would parse the 
2nd entry when the first one would be empty where the new code wouldn't, 
though since the new code uses a 16bit value instead of an 8bit one I'm 
not sure this interpretation is correct, as I've no idea how those bios 
tables really are supposed to look like).
In any case, it seems strange that wrong connector info would cause 
xvideo to not work, but otherwise the driver would be ok? Unless the 
video gets routed to the wrong port or something.

> Where should I send proposed patch?
bugzilla is good, though I guess there was a reason for the original 
change...

Roland