[PATCH] xserver -> libshadow linkage

Enrico Weigelt weigelt at metux.de
Thu Jun 1 04:21:38 PDT 2006

* Daniel Stone <daniel at freedesktop.org> schrieb:
> On Thu, Jun 01, 2006 at 11:03:52AM +0200, Enrico Weigelt wrote:
> > * Daniel Stone <daniel at freedesktop.org> schrieb:
> > > On Thu, Jun 01, 2006 at 02:29:20AM +0200, Enrico Weigelt wrote:
> > > > this patch removes the variable MIEXT_SHADOW_LIB and instead
> > > > links this lib to each Server directly. It makes thinks a little
> > > > bit clearer.
> > > 
> > > No.  Every other lib is done by variable substitution as part of
> > > $XSERVER_LIBS, $ddx_LIBS, or whatever, so why should miext/shadow be
> > > different, and the only one explicitly named?  If you're going to do
> > > this, why not miext/damage as well?
> > 
> > Since I'm gonna change them all, too. 
> > But just one step by another ...
> Why?

Cleanup. Make Reduce complexity. Make things more clear.
I don't see an valid reason, why there are dozens of variables, which
are set on an non-obvious position (somewhere deep in the configure 
script), used only once and are also contant.

For example, if you wanna see the dependencies of some DDX, you normally
start looking in the appropriate Makefile.am. Here you see you have 
you search for some variable and find out how it is defined and what
value it currently has. Since the dependencies of the DDX are mostly
the same, they could be written down directly in Makefile.am
Yes, we sometimes have conditional dependencies, but they can also be 
easily put there.

 Enrico Weigelt    ==   metux IT service - http://www.metux.de/
 Please visit the OpenSource QM Taskforce:
 Patches / Fixes for a lot dozens of packages in dozens of versions:

More information about the xorg mailing list