[PATCH] fbcmap.c -> xf86 DDX
ajax at nwnk.net
Sun Jun 4 08:59:20 PDT 2006
On Saturday 03 June 2006 05:44, Enrico Weigelt wrote:
> * Adam Jackson <ajax at nwnk.net> schrieb:
> > On Friday 02 June 2006 06:53, Enrico Weigelt wrote:
> > > Hi folks,
> > >
> > > this patch puts the appropriate code parts (w/o the conditionals) of
> > > fb/fbcmap.c to hw/xfree86/fbcmap.c, so we got it where it belongs.
> > >
> > > With the other DDX'es we should do the same ...
> > NACK. Though I am impressed at the hubris and dedication involved in
> > going ahead and doing exactly what you've already been told is wrong.
> Why not ?!
> Shouldn't the DDX (dependent) code go to the DDX ?
> I don't see what's wrong with this. Perhaps you could explain ?
I already explained this to you:
fbcmap.c should not be DDX-dependent. That it is, is a bug, and we're not
going to fix it by splitting the file up, because that's the wrong solution.
The correct solution is to fix the code to do consistent colormap handling
for all DDXes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the xorg