Slow X startup and Hammering /proc/pci

Daniel Stone daniel at freedesktop.org
Sun Jun 4 10:52:53 PDT 2006


On Sat, Jun 03, 2006 at 02:35:18PM +0100, Thomas Leonard wrote:
> On Sat, 03 Jun 2006 15:21:11 +0300, Daniel Stone wrote:
> > On Fri, Jun 02, 2006 at 08:28:33PM +0100, Thomas Leonard wrote:
> >> Here are four traces, showing each combination of patches:
> >> 
> >> http://www.ecs.soton.ac.uk/~tal/traces/
> >> 
> >> (ignore the last two points on each graph, as that just shows when I hit
> >> ctrl-alt-backspace to exit!)
> >> 
> >> Summary:
> >> 
> >> Original: 5.99 s
> >> With bugzilla patch: 5.07 s
> >> With my change: 4.31 s
> >> With both: 3.84 s
> > 
> > http://people.freedesktop.org/~daniels/xorg-pci-speedup.diff is extremely
> > nasty (lots of mangling between os-support/bus, and the OS subdirs), but
> > it does the trick.  Does it still give you the same performance boost?
> 
> No, because it still calls pciFindNext() on the last iteration of the loop...
> adding a break makes it work:
> 
> 	if (idx == xf86OSMaxPciDevs)
> 		break;
> 	tag = pciFindNext();

Gotcha.  Aside from that?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20060604/1b304b4c/attachment.pgp>


More information about the xorg mailing list