[patch] abstract socket support for xtrans

Arnaldo Carvalho de Melo acme at ghostprotocols.net
Sat Mar 18 16:02:30 PST 2006


On 3/18/06, Bill Crawford <billcrawford1970 at gmail.com> wrote:
> I'd appreciate very much if one or two people could test this to make sure it
> compiles and runs on non-i386 linux; it's tested and working on i386 linux,
> both old and new clients <-> old and new server side, here.
>
> Also, if you know abstract sockets work on your non-linux platform, please
> feel free to add that info to xtrans/configure.ac

I'm a noob on X hacking, so feel free to ignore me if you find my
suggestion annoying, but can you please try to avoid things like:

@@ -2124,7 +2205,6 @@

 static int
 TRANS(SocketRead) (XtransConnInfo ciptr, char *buf, int size)
-
 {
     PRMSG (2,"SocketRead(%d,%p,%d)\n", ciptr->fd, buf, size);

@@ -2144,7 +2224,6 @@

 static int
 TRANS(SocketWrite) (XtransConnInfo ciptr, char *buf, int size)
-
 {
     PRMSG (2,"SocketWrite(%d,%p,%d)\n", ciptr->fd, buf, size);

@@ -2164,7 +2243,6 @@

 static int
 TRANS(SocketReadv) (XtransConnInfo ciptr, struct iovec *buf, int size)
-
 {
     PRMSG (2,"SocketReadv(%d,%p,%d)\n", ciptr->fd, buf, size);

--------------------

As part of a new feature patch? Sending them in a different patch should
make the new feature patch smaller, easier to review.

Best Regards,

- Arnaldo



More information about the xorg mailing list