XGL source code error in xorg/GL/glx/glxdri.c file

[David Reveman]

On Thu, 2006-03-30 at 16:21 -0700, Brian Paul wrote:
> Colin Guthrie wrote:
> > Ioannis Nousias wrote:
> > 
> >> hello everyone. I'm new to the list and I hope this is the right place 
> >> to post this.
> >>
> >> as many others did :) I've also tried to compile the xgl-0-0-1 branch 
> >> of xserver from source. I was successful eventually, but came across 
> >> this error.
> >>
> >> glxdri.c: In function '__glXDRIdrawableCopySubBuffer':
> > 
> > 
> > Found the bug number:
> > 
> > https://bugzilla.novell.com/show_bug.cgi?id=157051
> > 
> > Col.
> 
> 
> Is there any risk to applying the CopySubBuffer patch to Mesa?  I.e. 
> this one: https://bugzilla.novell.com/attachment.cgi?id=72841&action=view

This is the same patch I sent to the mesa list. It should be safe. I can
only verify that the intel driver changes works as I haven't tried the
radeon changes myself.

> 
> I was planning on releasing 6.5 tomorrow.

It would be nice to have the dri interface change in 6.5.

My only concern is that from the last discussion on the mesa list, I'm
not sure everyone agreed that this was the best way to go for
accelerating partial front buffer updates. I planned on hooking up the
sync to vblank code I have for Xgl and make it work with the intel
driver to prove that MESA_copy_sub_buffer is the best way to go but I
haven't had the time to do that yet.

-David