PATCH: xserver configure

[Mark Pustjens]

-- 
In retrospect, Victor was always a little unclear about those next few
minutes. That's the way it goes. The moments that change your life are
the ones that happen suddenly, like the one where you die.
   (Moving Pictures)

On Wed, 10 May 2006, Donnie Berkholz wrote:

> Mark Pustjens wrote:
>> Hi all,
>>
>> This patch modifies configure.ac and a makefile to allow one to select
>> which Kdrive servers to build.
>>
>> It also gives a summary of what will be built.
>>
>> Please let me know what you think.
>
> I'm happy someone's done this work, but I have a few suggestions. Also
> there are a large number of gratuitous, unrelated formatting changes.
> Comments inline...
>
> Thanks,
> Donnie
>
>> ------------------------------------------------------------------------
>>
>> --- xserver-org/configure.ac	2006-01-05 13:01:23.000000000 +0100
>> +++ xserver-new/configure.ac	2006-05-10 10:19:25.000000000 +0200
>> @@ -377,6 +381,89 @@
>>  fi
>>  AM_CONDITIONAL(KDRIVEFBDEV, [test "$ac_cv_header_linux_fb_h" = yes])
>>
>> +if test "$KDRIVESERVER" = yes; then
>> +	for KSERVER in $ALL_KSERVERS; do
>> +		export KSERVER_$KSERVER="no"
>> +	done
>> +
>> +	AC_MSG_CHECKING(which kdrive servers to compile)
>> +	if test "$KSERVERS" = "all"; then
>> +		for KSERVER in $ALL_KSERVERS; do
>> +			export KSERVER_$KSERVER="yes"
>> +		done
>> +	elif test "$KSERVERS" != "none"; then
>> +		KSERVERS=`echo $KSERVERS| sed 's/,/ /g'`
>> +		for KSERVER in $KSERVERS; do
>> +			case $KSERVER in
>> +				ati|chips|ephyr|epson|fake|fbdev|i810|igs|ipaq|itsy|mach64|mga|neomagic|nvidia|pcmcia|pm2|r128|savage|sdl|sis300|sis530|smi|trident|trio|ts300|vesa|via|vxworks)
>
> Yet another full list of all the servers ... this duplication is not good.

i tried `$ALL_KSERVERS)' but it didn't work, thats the reason of the 
duplication. If you known how to fix this, please let me know.

>
> Also, do you need to actually be exporting all these variables? I
> thought they were only needed internally, not in the environment.

It is not needed, but without the export in front, KSERVER_$KSERVER="yes" 
is interpreted as a command. try it:

  foo=bar
  foo_$FOO=bar
bash: foo_=bar: command not found

again, if you have a solution....

>
>> +					export KSERVER_$KSERVER="yes"
>> +					;;
>> +				*)
>> +					AC_MSG_ERROR(unknown kdrive server $KSERVER, exiting!)
>> +					exit 1
>> +					;;
>> +			esac
>> +		done
>> +	fi
>> +	for KSERVER in $ALL_KSERVERS; do
>> +		eval KSERVER_YESNO=$`echo KSERVER_$KSERVER`
>> +		case $KSERVER in
>> +			vesa|mach64|mga|nvidia|r128|smi|chips|pm2|via|neomagic)
>
> Would prefer that these somehow be pulled into a variable farther up.
>
>> +				if test "$ac_cv_header_sys_vm86_h" = "no" -a "$KSERVER_YESNO" = "yes"; then
>> +					export KSERVER_$KSERVER="no"
>> +					AC_MSG_WARN(Cannot compile X$KSERVER, vesa support not found)
>> +				fi
>> +				;;
>> +			fbdev)
>> +				if test "$ac_cv_header_linux_fb_h" != "yes" -a "$KSERVER_YESNO" = "yes"; then
>> +					export KSERVER_$KSERVER="no"
>> +					AC_MSG_WARN(Cannot compile X$KSERVER)
>> +				fi
>> +				;;
>> +			ephyr)
>> +				if test "$xephyr" = "no" -a  "$KSERVER_YESNO" = "yes"; then
>> +					export KSERVER_$KSERVER="no"
>> +					AC_MSG_WARN(Cannot compile X$KSERVER)
>> +				fi
>> +				;;
>> +		esac
>
>