[Mesa3d-dev] Re: state of r200-copy-pixels patch for mesa ?

[David Reveman]

On Wed, 2006-05-24 at 07:42 -0600, Brian Paul wrote:
> David Reveman wrote:
> > On Wed, 2006-05-24 at 14:46 +0200, Hanno Böck wrote:
> > 
> >>Hi,
> >>
> >>A long while back, davidr posted a patch called r200-copy-pixels-1.patch 
> >>together with the first big xgl update telling that this would be required 
> >>for performant operation of xgl.
> >>
> >>This patch still applies to current mesa cvs. I wanted to ask if
> >>a) it still makes sense to apply this patch?
> >>b) if yes, this shouldn't be applied to upstream Mesa?
> >>
> >>Patch is here:
> >>http://svn.hboeck.de/xgl-overlay/media-libs/mesa/files/r200-copy-pixels-1.patch
> >>
> > 
> > 
> > Patch doesn't make sense anymore. Xgl now uses GLX_MESA_copy_sub_buffer
> > instead. Fast copy pixel performance is still useful but that patch is
> > no good.
> 
> Do you mean "the patch is no good for Xgl"?  Or, "the patch is defective"?
> 
> If it's not defective, I'll check it in.

It's defective. That patch was created as a quick hack to see how the
r200 driver performed with Xgl. It was never my intention that it would
go upstream.

I think Dave Airlie created a more appropriate patch for accelerating
CopyPixels.

-David