VESA crash when using randr

Gustavo Pichorim Boiko boiko at mandriva.com
Thu Oct 5 13:04:04 PDT 2006


Hi

I found a crash in VESA when trying to resize the screen using RandR . Looking 
at the code, and later in the internet, I found a patch fixing this.
http://www.redhat.com/archives/fedora-cvs-commits/2006-July/msg03489.html

-------------------------------------------------------------------------------- 
vesa.c.randr-crash        2006-06-03 05:46:00.000000000 -0400
+++ vesa.c    2006-07-28 16:56:44.000000000 -0400
@@ -1020,15 +1020,9 @@
 VESASwitchMode(int scrnIndex, DisplayModePtr pMode, int flags)
 {
     ScrnInfoPtr pScrn = xf86Screens[scrnIndex];
-    VESAPtr pVesa = VESAGetRec(pScrn);
     Bool ret;

-    if (pVesa->ModeSetClearScreen)
-       pScrn->EnableDisableFBAccess(scrnIndex,FALSE);
-    ret = VESASetMode(xf86Screens[scrnIndex], pMode);
-    if (pVesa->ModeSetClearScreen)
-       pScrn->EnableDisableFBAccess(scrnIndex,TRUE);
-    return ret;
+    return VESASetMode(pScrn, pMode);
 }

 /* Set a graphics mode */
--------------------------------------------------------------------------------

Is there any specific reason for this patch not to be commited upstream in the 
driver?

Thanks in advance
-- 
Gustavo Pichorim Boiko
----------------------
boiko @ mandriva . com
Mandriva - http://www.mandriva.com



More information about the xorg mailing list