[PATCH] Use autocofigured package version if possible. Update the module version to the autoconfigured one.

Giuseppe Bilotta giuseppe.bilotta at gmail.com
Tue Apr 24 18:14:42 PDT 2007


On 4/25/07, Alan Coopersmith <alan.coopersmith at sun.com> wrote:
> Daniel Stone wrote:
> > On Wed, Apr 25, 2007 at 03:06:26AM +0200, Giuseppe Bilotta wrote:
> >>  #ifdef HAVE_CONFIG_H
> >>  #include "config.h"
> >> +#else
> >> +#define PACKAGE_VERSION_MAJOR 1
> >> +#define PACKAGE_VERSION_MINOR 2
> >> +#define PACKAGE_VERSION_PATCHLEVEL 0
> >>  #endif
> >
> > When could HAVE_CONFIG_H possibly be unset?
>
> Now that we are no longer sharing source with the monolith, should
> all the #ifdef HAVE_CONFIG_H's be removed and just always include
> config.h now?

If this is the case, a sweeping change removing the #ifdef
HAVE_CONFIG_H *and* setting the module version to
PACKAGE_VERSION_MAJOR, ... in every module is probably the way to go.


-- 
Giuseppe "Oblomov" Bilotta



More information about the xorg mailing list