obvious thinko in kdrive.

[Bob Miller]

Dave Jones wrote:

> Just in case anyone still cares about kdrive, here's a patch
> for an obvious thinko.

Shouldn't that be "fd >= 0" anyway?  0 is a valid fd.

> diff --git a/hw/kdrive/linux/tslib.c b/hw/kdrive/linux/tslib.c
> index 41b74fa..81f753e 100644
> --- a/hw/kdrive/linux/tslib.c
> +++ b/hw/kdrive/linux/tslib.c
> @@ -118,7 +118,7 @@ TslibEnable (KdPointerInfo *pi)
>      private->fd = ts_fd(private->tsDev);
>      if (!private->tsDev || ts_config(private->tsDev) || private->fd < 0) {
>          ErrorF("[tslib/TslibEnable] failed to open %s\n", pi->path);
> -        if (private->fd > 0);
> +        if (private->fd > 0)
>              close(private->fd);
>          return BadAlloc;
>      }
> 
> -- 
> http://www.codemonkey.org.uk
> _______________________________________________
> xorg mailing list
> xorg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg

-- 
Bob Miller                              K<bob>
                                        kbob at jogger-egg.com