[PATCH libXfont] improve error handling on catalogue:<dir> implementation

Kristian Høgsberg krh at bitplanet.net
Sun Jul 8 12:01:34 PDT 2007

On 7/5/07, Ademar de Souza Reis Jr <ademar at mandriva.com.br> wrote:
> ---
>  src/fontfile/catalogue.c |   20 ++++++++++++++------
>  1 files changed, 14 insertions(+), 6 deletions(-)

Actually, my intention was that if the rescan fails for some reason,
it should be a no-op.  I.e. just keep the old list and pretend nothing
changed, so that we can just ignore the rescan return code in all
cases except the fpe init case.  That will let the X server keep
running in the case of fatal failure (such as removing the fontpath.d
directory).  Of course, if the fpe init case fails, we need to report
that back.

As it is, the code doesn't actually behave that way, but moving the
Catalogue alloc and initialization into the rescan function, and only
setting fpe->private when everything succeeds will achieve that.


More information about the xorg mailing list