[PATCH] miTrapezoids(): Simplify.

Keith Packard keithp at keithp.com
Wed Jul 11 15:37:46 PDT 2007

On Wed, 2007-07-11 at 18:09 -0400, Bernardo Innocenti wrote:
> It striked me that miTrapezoids() called itself recursively.

Yes, the semantics require one-at-a-time drawing when maskFormat is not
specified, the easiest way to do that was the recursive form.

> The current form is probably the result of successive changes.

No, that was the initial implementation.

> Lightly tested and even more lightly understood, so apply at
> your own risk.

This patch generates incorrect semantics.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20070711/9b22b47e/attachment.pgp>

More information about the xorg mailing list