[patch 1/2] xserver crtc: add quirk_detailed_sync_pp for samsung 205BW

[Maarten Maathuis]

Shouldn't edid quirks go into the xserver, or is this something
specific to intel drivers?

Maarten Maathuis.

On 11/8/07, Hong Liu <hong.liu at intel.com> wrote:
> Fix bug #12439: add a quirk to use +hsync +vsync for the probed detailed mode.
>
> Thanks,
> Hong
>
>
> diff --git a/hw/xfree86/modes/xf86EdidModes.c b/hw/xfree86/modes/xf86EdidModes.c
> index 2f26a64..427a10b 100644
> --- a/hw/xfree86/modes/xf86EdidModes.c
> +++ b/hw/xfree86/modes/xf86EdidModes.c
> @@ -66,6 +66,8 @@ typedef enum {
>      DDC_QUIRK_DETAILED_USE_MAXIMUM_SIZE = 1 << 5,
>      /* Monitor forgot to set the first detailed is preferred bit. */
>      DDC_QUIRK_FIRST_DETAILED_PREFERRED = 1 << 6,
> +    /* use +hsync +vsync for detailed mode */
> +    DDC_QUIRK_DETAILED_SYNC_PP = 1 << 7,
>  } ddc_quirk_t;
>
>  static Bool quirk_prefer_large_60 (int scrnIndex, xf86MonPtr DDC)
> @@ -159,6 +161,15 @@ static Bool quirk_first_detailed_preferred (int scrnIndex, xf86MonPtr DDC)
>      return FALSE;
>  }
>
> +static Bool quirk_detailed_sync_pp(int scrnIndex, xf86MonPtr DDC)
> +{
> +    /* Bug #12439: Samsung SyncMaster 205BW */
> +    if (memcmp (DDC->vendor.name, "SAM", 4) == 0 &&
> +       DDC->vendor.prod_id == 541)
> +       return TRUE;
> +    return FALSE;
> +}
> +
>  typedef struct {
>      Bool       (*detect) (int scrnIndex, xf86MonPtr DDC);
>      ddc_quirk_t        quirk;
> @@ -194,6 +205,10 @@ static const ddc_quirk_map_t ddc_quirks[] = {
>         quirk_first_detailed_preferred, DDC_QUIRK_FIRST_DETAILED_PREFERRED,
>         "First detailed timing was not marked as preferred."
>      },
> +    {
> +       quirk_detailed_sync_pp, DDC_QUIRK_DETAILED_SYNC_PP,
> +       "Use +hsync +vsync for detailed timing."
> +    },
>      {
>         NULL,           DDC_QUIRK_NONE,
>         "No known quirks"
> @@ -334,15 +349,19 @@ DDCModeFromDetailedTiming(int scrnIndex, struct detailed_timings *timing,
>      if (timing->interlaced)
>          Mode->Flags |= V_INTERLACE;
>
> -    if (timing->misc & 0x02)
> -       Mode->Flags |= V_PVSYNC;
> -    else
> -       Mode->Flags |= V_NVSYNC;
> -
> -    if (timing->misc & 0x01)
> -       Mode->Flags |= V_PHSYNC;
> -    else
> -       Mode->Flags |= V_NHSYNC;
> +    if (quirks & DDC_QUIRK_DETAILED_SYNC_PP)
> +       Mode->Flags |= V_PVSYNC | V_PHSYNC;
> +    else {
> +       if (timing->misc & 0x02)
> +           Mode->Flags |= V_PVSYNC;
> +       else
> +           Mode->Flags |= V_NVSYNC;
> +
> +       if (timing->misc & 0x01)
> +           Mode->Flags |= V_PHSYNC;
> +       else
> +           Mode->Flags |= V_NHSYNC;
> +    }
>
>      return Mode;
>  }
> _______________________________________________
> xorg mailing list
> xorg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg
>