regression in X11R7.2?

[Jack Howarth]

Nicolas,
    I rebuilt my xview rpms with debug flags and
I find that openwin clock client shows the following debug trace
under Fedora 8...

Program received signal SIGABRT, Aborted.
0x00110402 in __kernel_vsyscall ()
(gdb) bt
#0  0x00110402 in __kernel_vsyscall ()
#1  0x0031f690 in raise () from /lib/libc.so.6
#2  0x00320f91 in abort () from /lib/libc.so.6
#3  0x0031893e in __assert_fail () from /lib/libc.so.6
#4  0x075cc599 in _XAllocID () from /usr/lib/libX11.so.6
#5  0x001d3fd1 in server_init (parent=0, server_public=164910592, avlist=0xbfa89414) at server.c:784
#6  0x00227a54 in xv_create_avlist (parent=0, pkg=<value optimized out>, avlist=0xbfa89414) at xv.c:391
#7  0x00227c00 in xv_create (parent=0, pkg=0x25a520) at xv.c:307
#8  0x00229867 in xv_init (attr1=1241974786) at xv_init.c:308
#9  0x0804cb34 in init_clck (argc=1, argv=0xbfa89e94) at clock.c:1752
#10 0x0804d5cc in main (argc=Cannot access memory at address 0x1ebb
) at clock.c:2093

which corresponds to the following code for the server in libxview...

    /*
     * End of Sundae buyback code replacement for
     *    defaults_load_db(filename);
     *    defaults_load_db((char *) NULL);
     */

    /* Used by atom mgr */
    server->atom_mgr[ATOM] = (XID) XAllocID((Display *)server->xdisplay);
    server->atom_mgr[NAME] = (XID) XAllocID((Display *)server->xdisplay);
    server->atom_mgr[TYPE] = (XID) XAllocID((Display *)server->xdisplay);
    server->atom_mgr[DATA] = (XID) XAllocID((Display *)server->xdisplay);

where the offending line is...

    server->atom_mgr[NAME] = (XID) XAllocID((Display *)server->xdisplay);

There were no particular warnings that stood out when compiling this file...

gcc -m32 -fPIC   -O2 -fno-strength-reduce -fno-strict-aliasing    -I/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include  -I/tmp/xview-3.2p1.4-21.1.fc8-soft/usr/openwin/include -I../../../build/include  -I/usr/include    -Dlinux -D__i386__ -D_POSIX_C_SOURCE=199309L                            -D_POSIX_SOURCE -D_XOPEN_SOURCE                                 -D_BSD_SOURCE -D_SVID_SOURCE                           -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64                                                             -I/include -DX11R6 -Di386 -DNO_CAST_VATOAV -DFUNCPROTO=15 -DNARROWPROTO   -DOS_HAS_LOCALE -DOS_HAS_MMAP               -DDYNAMICLIB -DOPENWINHOME_DEFAULT=\"/usr/openwin\" -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables  -c server.c -o shared/server.o
In file included from server.c:23:
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/ndet.h:191: warning: type defaults to ‘int’ in declaration of ‘ndet_check_fd’
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/ndet.h:195: warning: type defaults to ‘int’ in declaration of ‘ndet_check_sig’
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/ndet.h:198: warning: type defaults to ‘int’ in declaration of ‘ndet_check_mode’
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/ndet.h:204: warning: type defaults to ‘int’ in declaration of ‘ndet_check_which’
In file included from server.c:36:
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/svr_kmdata.h:37: warning: missing braces around initializer
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/svr_kmdata.h:37: warning: (near initialization for ‘sunview1_kbd_cmds[0]’)
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/svr_kmdata.h:116: warning: missing braces around initializer
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/svr_kmdata.h:116: warning: (near initialization for ‘basic_kbd_cmds[0]’)
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/svr_kmdata.h:216: warning: missing braces around initializer
/home/howarth/rhdev/BUILD/xview-3.2p1.4/build/include/xview_private/svr_kmdata.h:216: warning: (near initialization for ‘full_kbd_cmds[0]’)
server.c:122: warning: missing braces around initializer
server.c:122: warning: (near initialization for ‘xv_kbd_cmds_value_pairs[0]’)
server.c: In function ‘server_yield_modifiers’:
server.c:274: warning: suggest parentheses around assignment used as truth value
server.c: In function ‘server_init’:
server.c:472: warning: suggest parentheses around assignment used as truth value
server.c:475: warning: assignment makes integer from pointer without a cast
server.c:621: warning: implicit declaration of function ‘bindtextdomain’
server.c:643: warning: suggest parentheses around assignment used as truth value
server.c:653: warning: suggest parentheses around assignment used as truth value
server.c:694: warning: suggest parentheses around assignment used as truth value
server.c:838: warning: implicit declaration of function ‘selection_init_agent’
server.c:372: warning: unused variable ‘character_set’
server.c: In function ‘server_get_locale_from_str’:
server.c:1217: warning: label ‘defaults’ defined but not used
server.c: In function ‘server_setlocale_to_default’:
server.c:1288: warning: unused variable ‘msg’
server.c: In function ‘server_destroy’:
server.c:1363: warning: suggest parentheses around assignment used as truth value
server.c: In function ‘destroy_atoms’:
server.c:1480: warning: suggest parentheses around assignment used as truth value
server.c: In function ‘server_init_atoms’:
server.c:1560: warning: passing argument 1 of ‘xv_error’ makes integer from pointer without a cast
server.c: In function ‘server_warning’:
server.c:1849: warning: passing argument 1 of ‘xv_error’ makes integer from pointer without a cast
server.c: At top level:
server.c:1059: warning: ‘server_effect_locale’ defined but not used

Oddly the first call to XAllocID succeeded...

    server->atom_mgr[ATOM] = (XID) XAllocID((Display *)server->xdisplay);

Any ideas?
              Jack