[PATCH] [xserver] XInput extended button press/release report regression

Daniel Stone daniel at fooishbar.org
Fri Nov 30 10:37:40 PST 2007

On Sun, Nov 25, 2007 at 02:49:50AM +0200, Daniel Stone wrote:
> On Sat, Nov 24, 2007 at 10:59:12PM +0100, Magnus Vigerlöf wrote:
> > We (linuxwacom) had some strange reports about button presses that got out of 
> > sync with the actual button mapping for the InputDevice. This has shown up 
> > starting with xserver 1.4.
> > 
> > I've tracked it down to a button conversion made twice only for extended input 
> > events, which was introduced with xserver 1.4/input rework.
> > 
> > The two places where the conversion is made today are here:
> > ./dix/getevents.c:656 in GetPointerEvents
> > ./Xi/exevents.c:237 in ProcessOtherEvent
> > ---
> > Remove duplicate button press/release translation for extended events.
> Thanks, but the patch should be the other one: core events should get
> the button map from the extended mouse, and ProcessOtherInput shouldn't
> modify the detail field at all.

I've pushed this to master and 1.4 branch.  Thanks for the heads up:
good to know someone's using all this stuff.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20071130/4d380482/attachment.pgp>

More information about the xorg mailing list