[xf86-video-intel] pI830->memory_manager is freed twice

Zhenyu Wang zhenyu.z.wang at intel.com
Mon Oct 8 21:50:50 PDT 2007

On 2007.10.09 12:16:58 +0000, Zhenyu Wang wrote:
> Yeah, it also does the trick that if we failed in first try on tiled allocation,
> we can't free memory_manager, as it's needed for second try. But with this we still 
> might have leak here if both trys fail, we will leave memory_manager. Coz memory_manager 
> is freed only in i830_allocator_fini() (called by pScreen->CloseScreen) after taking 
> down ttm. As we failed in ScreenInit, we don't have chance to free it. I think this
> is rare and shouldn't happen practically.

The fix seems simple by calling i830_allocator_fini() before we return fail.
And we'd better fix to use xfree() for freeing memory_list start/end marker.

More information about the xorg mailing list