possible logic error in intel tvout code?

rglowery at exemail.com.au rglowery at exemail.com.au
Tue Oct 16 02:45:21 PDT 2007

In src/i830_tv.c

we have

1055         case TV_TYPE_COMPONENT:
1056             tv_ctl |= TV_ENC_OUTPUT_COMPONENT;
1057             video_levels = &component_level;
1058             if (tv_mode->burst_ena)
1059                 color_conversion = &sdtv_component_color;
1060             else
1061                 color_conversion = &hdtv_component_color;
1062             burst_ena = FALSE;
1063             break;

However, all of the component modes (eg 576p etc) have burst_ena = FALSE. 
Only the old SD modes eg PAL, NTSC etc have burst_ena = TRUE

If I understand this correctly, the
if (tv_mode->burst_ena)

should be

if (!tv_mode->burst_ena)

or perhaps

if (tv_mode->component_only)

could someone please confirm my analysis is correct?



More information about the xorg mailing list