xserver: Branch 'master' - 2 commits

Luc Verhaegen libv at skynet.be
Thu Oct 18 09:03:23 PDT 2007

On Wed, Oct 17, 2007 at 10:17:15PM +0800, Keith Packard wrote:
> On Wed, 2007-10-17 at 15:25 +0200, Luc Verhaegen wrote:
> > Ah, so in effect, it is a further subspecification of M_T_PREFERRED.
> > Understood.
> Yeah, that's why it took me a while to fix this problem -- I had to
> figure out that it mattered where the preference was stated, not only
> where the mode was defined.
> > Wouldn't it make more sense to define this as
> > #define M_T_PREFERRED_USER 0x04
> > to further distinguish the PREFERRED case in the lower nibble, and to 
> > always set the PREFERRED bit next to this?
> Or perhaps M_T_PREFERRED_DRIVER and M_T_PREFERRED_USER. Given that the
> names are hidden entirely within the xf86/modes implementation, it
> doesn't really make that much difference to me though. M_T_USERPREF is
> probably not the best choice at any rate.
> I didn't look at the values to try and detect a pattern; if 0x04 is
> free, it would be fine to use that instead of the higher value.

Yeah, any of the three lower bits should be fine here. Next big API/ABI 
breakage, we probably might want to move these things to seperate 
bytes inside the int sized Mode->type.

Luc Verhaegen.
SUSE/Novell X Driver Developer.

More information about the xorg mailing list