VNC patch for Xserver 1.3

[Stefan Dirsch]

On Fri, Oct 19, 2007 at 09:10:09AM -0700, Dan Nicholson wrote:
> On Fri, Oct 19, 2007 at 05:03:51PM +0200, Stefan Dirsch wrote:
> > On Fri, Oct 19, 2007 at 08:01:34AM -0700, Dan Nicholson wrote:
> > > On 10/18/07, Stefan Dirsch <sndirsch at suse.de> wrote:
> > > >
> > > > Finally I gave your patch a try. Unfortunately it suffers from the same
> > > > problem as mentioned before. The Xserver crashes when the libvnc module
> > > > is loaded.
> > > >
> > > > (**) Mouse[3]: always reports core events
> > > > (II) evaluating device (Mouse[3])
> > > >
> > > > Backtrace:
> > > > 0: X(xf86SigHandler+0x6a) [0x496f0a]
> > > > 1: /lib64/libc.so.6 [0x2b5221649ba0]
> > > > 2: /lib64/libc.so.6(strlen+0x40) [0x2b522168eba0]
> > > > 3: X(xf86ActivateDevice+0x59) [0x499279]
> > > > 4: X(InitInput+0x4d) [0x46785d]
> > > > 5: X(main+0x370) [0x436210]
> > > >
> > > > I'm wondering why you don't see this problem.
> > > 
> > > I've only been using Xvnc, not the vnc module. I gave a quick whirl on
> > > libvnc (linux x86), and the server doesn't crash immediately. I
> > > haven't actually tried to connect, though. Is this crash you're seeing
> > > on startup?
> > 
> > Yes. How does your configuration (xorg.conf) look like?
> 
> The vnc options are currently commented out, 

... which explains why this issue doesn't happen to you. As long as
you don't enalbe the sections in ServerLayout you won't get the crash
and the access to your Xserver either.

> but here it is.  One thing to note is that I have all my current
> input devices specified as evdev devices in xorg.conf.

... which doesn't matter.

> Section "ServerLayout"
>       [...]
> 	#InputDevice	"VNC Mouse" "ExtraPointer"
> 	#InputDevice	"VNC Keyboard" "ExtraKeyboard"
InputDevice	"VNC Mouse" "ExtraPointer"
InputDevice	"VNC Keyboard" "ExtraKeyboard"

> Section "Module"
> 	#Load  "vnc"
Load  "vnc"

> Section "InputDevice"
> 	Identifier  "VNC Mouse"
> 	Driver      "rfbmouse"
> EndSection
> 
> Section "InputDevice"
> 	Identifier  "VNC Keyboard"
> 	Driver      "rfbkeyb"
> EndSection
Looks good.

> Section "Device"
> 	#Option      "UseVNC"                    "yes"
Option  "usevnc" "yes"

Best regards,
Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
-----------------------------------------------------------------
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-----------------------------------------------------------------