[PATCH] xprint is broken in xserver git
daniel at fooishbar.org
Wed Sep 5 07:24:42 PDT 2007
On Wed, Sep 05, 2007 at 11:17:41PM +1000, Drew Parsons wrote:
> On Wed, 2007-09-05 at 18:44 +1000, Drew Parsons wrote:
> > I've had a go at implementing this second option, building a local
> > libconfig.a.
> > The only solution that stays on this path
> > is to add a check within config.c to see if PRINT_ONLY_SERVER or
> > somesuch is defined (a similar problem is in fact handled this way in
> > mi/miinitext.c, which has to be compiled locally for Xprint).
> > So the two options become
> > 1) adding a small, ugly but harmless hack to the Xprint code to manage
> > HAL support which it does not in fact use
> > 2) adding a small but logically tricky hack to config.c, enabling an
> > Xprint-specific libconfig.a to be compiled.
> > In the interests of keeping the non-Xprint code unmangled and tidy for
> > the rest of you, I'll apply the first option, based on Maarten's patch.
> For reference, I'm attaching a patch implementing the second (undesired)
> solution. But looks like Eric has applied a patch in the meantime that
> fixes the build anyway.
Well, it means you do double-compilation, which sucks. With
NewInputDeviceRequest and DeleteInputDeviceRequest being no-ops, there's
zero net effect: the config framework does nothing on its own, just
hints the DDX towards what it may want to do. So I don't think there
really needs to be any change at all.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: Digital signature
More information about the xorg