[patch] exa: fix pitch handling in ModifyPixmapHeader

[Tilman Sauerbeck]

Tilman Sauerbeck [2008-04-19 19:21]:
> Tilman Sauerbeck [2008-04-18 20:48]:
> > Tilman Sauerbeck [2008-04-18 19:35]:
> > > Zhenyu Wang [2008-04-19 09:16]:
> > > > On 2008.04.18 14:03:50 +0200, Tilman Sauerbeck wrote:
> > > > > Unfortunately I cannot reproduce #15509 on my i945 sofar. I tried the
> > > > > master branches of xserver.git and intel.git with a framebuffer of
> > > > > 2560x2560 pixels, and rotation still worked fine after I connected the
> > > > > VGA output and extended my desktop to it.
> > > > 
> > > > Try to set virtual height <= 2048. Current intel driver will disable
> > > > accel if virtualY's larger than 2048, which I think a little overkill.
> > > > As hw at least supports 2D blit larger than that, and disable smaller
> > > > size pixmap acceleration totally. I don't know much of why it is, Eric?
> > > 
> > > Thanks, I can reproduce the crash with a framebuffer of 2432x1024
> > > pixels. I'll look into it.
> > 
> > The crash I'm seeing happens in exaFillRegionTiled. Exa is trying to
> > copy to the screen pixmap (1024x768 in my case, with the pitch being
> > 16384).
> > 
> > The problem is that exaSetAccelBlock() was never called for the screen
> > pixmap, so accel_block is zero and Exa tries to pass it to PrepareCopy.
> > 
> > Looking for the proper fix now...
> 
> The attached patch sets the accel_block thing for the screen pixmap as
> well. For xf86-video-intel, another patch is needed, because it
> currently lies to the lower layers about the dimensions of the screen
> pixmap. Comments?
> 
> btw, there's still some cases left where pExaPixmap->accel_block is
> messed up, I'm looking for the cause atm.

I think that was just bad testing. I don't see any problems anymore if I
also set
   pI830->EXADriverPtr->maxPitchBytes = 8192;
in the driver. ie, with that line, the safeguard in
i830_exa_check_pitch_?d isn't hit anymore.

I'll stop replying to myself now :)

Regards,
Tilman

-- 
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20080419/f97319aa/attachment.pgp>